:Template talk:AfC submission#Template-protected edit request on 24 April 2025

• Warning: The page {{xt|Article}} already exists. Please ensure it is not a copy or that this page is located to the correct title.

Is the underlined text supposed to be read as "located at" or "relocated to"? Please fix that if you can. – MrPersonHumanGuy (talk) 23:25, 6 March 2025 (UTC)

:Looks like a grammar error to me. It comes from Special:Diff/856957555 where {{tq|Please verify that it is not a copy of this submission and that this page does not need to be moved to a different title.}} was shortened to {{tq|Please verify that it is not a copy of this submission or that this page is located to the correct title.}} Pinging @Headbomb, who made the edit, in case there's a grammar subtlety I've missed. Chaotic Enby (talk · contribs) 23:52, 6 March 2025 (UTC)

::Fixed. Thanks for the ping. Headbomb {t · c · p · b} 01:15, 7 March 2025 (UTC)

{{edit template-protected|Template:AfC submission/comments|answered=yes}}

For the decline reason notenglish, change "Have you visited the [https://www.wikipedia.org Wikipedia home page]? You can probably find a version of Wikipedia in your language." to "Otherwise, you may be able to find a version of Wikipedia in your language at the [https://www.wikipedia.org Wikipedia home page] and write the article there."

IMO, this sounds more formal and the previous wording has a question, which the other decline reasons do not have. ~ Rusty ^meow ~ 16:00, 22 March 2025 (UTC)

:I agree with this change, the current version also sounds more condescending than your proposal. Chaotic Enby (talk · contribs) 18:52, 22 March 2025 (UTC)

:{{complete2}}. P.I. Ellsworth , ed. ^{put'er there} 06:05, 23 March 2025 (UTC)

{{Moved to|Wikipedia talk:WikiProject Articles for creation#Unhelpful}}

{{archive top|Per the last suggestion, I have started a discussion at {{section link|WT:AFC|Proposing new parameter for Template:AfC submission/declined}}. – MrPersonHumanGuy (talk) 23:58, 6 May 2025 (UTC)}}

{{see also|Wikipedia:Village pump (idea lab)/Archive 66#What to do about prior draft decline notices}}

{{edit template-protected|Template:AfC submission/declined|answered=yes}}

I recently created {{tl|AfC notice shell}}, which serves an analogous purpose to {{tl|WikiProject banner shell}}, but for instances of {{tl|AfC submission}} on drafts. However, the submission template uses {{tl|ombox}}, which makes itself somewhat narrow than... wherever it is displayed. Although that is fine for general display, it results in a significant mismatch of width when placed inside the holder.

{{AfC notice shell|

{{AfC submission|D|small=yes}}

{{ombox|text=This is {{tl|ombox}}, which these notices currently use.}}

{{fmbox|text=This is {{tl|fmbox}}, which stretches further horizontally.}}

}}

Description of suggested change: Add the parameter {{code|wide}} to {{tl|AfC submission/declined}}.

{{archive top|reason=If implemented, the wide version of the template would be white instead of light pink because, even though {{code|notice}} is a valid value for the {{code|type}} parameter on {{tl|ombox}}, it's not a valid value for the same parameter on {{tl|fmbox}}. – MrPersonHumanGuy (talk) 18:47, 25 April 2025 (UTC)}}

Diff:

{{text diff

|{{Ombox

| templatestyles = AfC submission/styles.css

...

|{{{{#ifeq:{{{wide|}}}|yes|Fmbox|Ombox}}

| templatestyles = AfC submission/styles.css

...

}}

{{archive bottom}}

Then, if {{AfC submission/declined|wide=yes}} or {{AfC submission|D|wide=yes}} are inserted within the notice holder, the result should look something like this:

{{AfC notice shell|

{{Fmbox

| templatestyles = AfC submission/styles.css

| style = background:#fee;

| class = afc-submission-declined

| image = none

| imageright = File:AFC-Logo_Decline.svg

| text = Submission declined on 5 November by Guy Fawkes (talk){{#if: {{{decliner|}}}{{{declinets|}}}

| {{#if: {{{declinets|}}}

| on {{#time: j F Y|{{{declinets}}}}}{{#if: {{{decliner|}}}

|

}}

}}{{#if: {{{decliner|}}}

|by {{Noping|{{{decliner}}}}} (talk)

}}

}}.{{#if:{{NAMESPACE}}{{#ifeq:{{REVISIONID}}|{{REVISIONID:{{FULLPAGENAME}}}}||0}} |{{#if: testing

|

}}{{#if: {{{reason2|}}}

|

}}}}{{#ifeq: {{lc: {{{small|}}} }} | yes|

|

{{#if:{{NAMESPACE}}||}}{{#ifexpr: {{#time: U | {{{revisionts|{{REVISIONTIMESTAMP}}}}} +6 months }} < {{#time: U}}|

{{#ifexpr: ({{#time: U | {{{revisionts|{{REVISIONTIMESTAMP}}}}} +5 months}} < {{#time: U}})and({{#time: U | {{{revisionts|{{REVISIONTIMESTAMP}}}}} +6 months}} > {{#time: U}})|{{#if:{{{demo|}}}||{{REVISIONTIMESTAMP}}}}}}

}}{{#if: {{{decliner|}}}

}}{{#ifeq: {{lc: {{{small|}}} }} | yes|| Last edited {{#if: {{REVISIONUSER}}

}}{{main other||2=

}}

}}

I first suggested both the template and the parameter at {{section link|Wikipedia:Village pump (idea lab)|What to do about prior draft decline notices}}, where you may wish to comment. – MrPersonHumanGuy (talk) 12:21, 24 April 2025 (UTC)

:{{question}} Why is this not being prototyped at Template:AfC submission/declined/sandbox, and why is it not being tested at Template:AfC submission/declined/testcases? See WP:TESTCASES. --Redrose64 🌹 (talk) 16:47, 25 April 2025 (UTC)

:{{block indent|em=1.6|1=Notified: WT:AFC. –Novem Linguae (talk) 17:44, 25 April 2025 (UTC)}}

::I oppose this change as it will cause reviewers to make another action (click show) in order to properly review a draft. Each action just takes more time. S0091 (talk) 17:47, 25 April 2025 (UTC)

:::So is the notice shell just collapsing prior reviews? Because if so I’m gonna have to be mildly against this as it is just creating extra steps for.. aesthetics? Sophisticatedevening🍷^(talk) 18:11, 25 April 2025 (UTC)

::::Not showing the submitted a giant wall of "your draft sucks!!" every time they look at it seems desirable, but I would want to see the decline. Is it possible to do something like the "many issues" box that provides a short summary of previous decline notices? Perhaps something like:

::::* Declined on 5 November by Guy Fawkes for notability & copyright violations

::::* Declined on 4 November by Rusalkii for verifiability

::::Rusalkii (talk) 18:18, 25 April 2025 (UTC)

::After [https://en.wikipedia.org/w/index.php?title=Template%3AAfC_submission%2Fdeclined%2Fsandbox&diff=1287356258&oldid=1253540279 using the sandbox] and putting up testcases for show and tell, I've decided to revise my specific suggestions for things I overlooked:

{{text diff

|{{Ombox

| templatestyles = AfC submission/styles.css

| class = afc-submission-declined

| type = notice

| image = none

...

|{{{{#ifeq:{{{wide|}}}|yes|Fmbox|Ombox}}

| templatestyles = AfC submission/styles.css

| class = afc-submission-declined

| type = {{#ifeq:{{{wide|}}}|yes|system|notice}}

| style = background:#fee

| image = none

...

}}

::I now recognize that I should've made use of those pages in the beginning and I apologize for not having done so. – MrPersonHumanGuy (talk) 18:16, 25 April 2025 (UTC)

:::{{replyto|MrPersonHumanGuy}} With templates, it's never a good idea to paste code blobs into a talk page, they can't be tested directly, and it can be tricky to make the formatting show correctly when both editing and reading. I think that it might have been better if you had started off by copying the present version of Template:AfC submission/declined to Template:AfC submission/declined/sandbox and saving that. Then make your changes to that sandbox. Then set up some testcases, but not by pasting the template code into the testcases page, as you seem to have done {{diff|Template:AfC submission/declined/testcases|1287360303|1151275748|here}} - have a look at the [https://en.wikipedia.org/w/index.php?title=Template:AfC_submission/declined/testcases&action=history page history], particularly the edits by Ahecht and Primefac, to see how such pages are normally used. --Redrose64 🌹 (talk) 13:22, 26 April 2025 (UTC)

::::{{done}}... I think. This time, I've decided to leave my proposed changes to the template on its sandbox counterpart to allow for further testing. I didn't think your advice to check the edit history of the /testcases page was as helpful as you might've hoped, as what ends up on a page may not necessarily always match exactly what a user types in (especially not when templates are substituted), so I decided to look for an instructional page instead. I came across {{section link|WP:TESTCASES|Basic format}} and decided to reformat my tests to be in line with what is demonstrated there. – MrPersonHumanGuy (talk) 14:32, 26 April 2025 (UTC)

:File:X mark.svg Not done for now: please establish a consensus for this alteration before using the {{Tlx|Edit template-protected}} template. Currently a reasonable amount of opposition to this. Feel free to continue discussing though. Primefac (talk) 14:47, 26 April 2025 (UTC)

::I suggest starting a discussion at WT:AFC as this will impact AfC reviewer's processes and I think you need to clear about how this is a benefit. To me, it needs to be a benefit to both the creators and the reviewers (a win win). S0091 (talk) 19:04, 26 April 2025 (UTC)

{{archive bottom}}

Hey @Primefac, noticing an extra space between the declination history and the start of the comments, I'm wondering the the [https://en.wikipedia.org/w/index.php?title=Template:AfC_submission&diff=prev&oldid=1289883112 May 11] edit may have caused this, or if anyone else has noticed a similar change recently. I am able to reproduce in Firefox and on Edge. Bobby Cohn 🍁 (talk) 20:39, 12 May 2025 (UTC)

:Huh, probably was. Thanks. Primefac (talk) 01:20, 13 May 2025 (UTC)

{{Edit template-protected|Template:AfC submission/comments|answered=yes}}

Request to add new decline option of cat at Template:AfC submission/comments. I have done a change in the sandbox as well: Special:Diff/1291327355. This is in line with the github pull request for AFCH at https://github.com/wikimedia-gadgets/afc-helper/pull/407 and issue at https://github.com/wikimedia-gadgets/afc-helper/issues/363. Note:I'm okay with putting this on hold till the PR review. Thanks! — ~/Bunnypranav:<ping> 14:29, 20 May 2025 (UTC)

:This had a bug, which I fixed [https://en.wikipedia.org/w/index.php?title=Template:AfC_submission/comments/sandbox&diff=prev&oldid=1291413396 here]. The bug was that |notenglish would have been detected as |cat since it was above |cat. –Novem Linguae (talk) 02:29, 21 May 2025 (UTC)

::{{done}}. I also edited Template:AfC submission/comments/doc to add cat to that. –Novem Linguae (talk) 02:37, 21 May 2025 (UTC)

:::Thanks! ~/Bunnypranav:<ping> 03:05, 21 May 2025 (UTC)