Module talk:External links

I found two errors in this module that need fixing:

• Line number 562 and line number 666 ({{code|1=if not (local_value or local_value == ) then|lang=lua}}): The "not" is extended to the whole expression via parentheses, when it looks like it was meant to be {{code|1=not local_value or local_value == |lang=lua}}. By De Morgan's laws, it is currently equivalent to {{code|1=not local_value and local_value ~= ''|lang=lua}}, which is just {{code|1=not local value|lang=lua}}
• Line number 931 ({{code|1=local somedataonwikidata = (short_links and false or true)|lang=lua}}: This was clearly meant to be a use of lua's ternary expression "syntax" (for lack of a better word). However, the or will always trigger, as false is, well, falsy; as such, this expression will always short-circuit to {{code|1=local somedataonwikidata = true|lang=lua}}. This should probably instead be {{code|1=local somedataonwikidata = not short_links|lang=lua}}.

{{Lemondoge|Talk|Contributions}} 22:11, 12 April 2023 (UTC)

:Update: Now {{done|done}}. {{Lemondoge|Talk|Contributions}} 18:44, 9 May 2023 (UTC)

I object to the subjective change of shown link limits implemented by {{Ping|User:S.A. Julio}}. For further discussion, please see Template talk:Sports links#Link Limits. GauchoDude (talk) 16:35, 19 August 2024 (UTC)