Wikipedia:Bots/Requests for approval/DannyS712 bot 9
[[User:DannyS712 bot|DannyS712 bot 9]]
{{Newbot|DannyS712 bot|9}}
Operator: {{botop|DannyS712}}
Time filed: 10:11, Friday, March 1, 2019 (UTC)
Automatic, Supervised, or Manual: automatic
Programming language(s): AutoWikiBrowser
Source code available: AWB
Function overview: The task of the bot would be to identify all articles in :Category:Articles needing translation from French Wikipedia who have a French Commune infobox, then add the |topic=geo parameter to their Expand French template, to categorize them in :Category:Geography articles needing translation from French Wikipedia. (copied from bot request)
Links to relevant discussions (where appropriate): WP:BOTREQ#Bot to reorganize the French Communes articles in Category:Articles needing translation from French Wikipedia
Edit period(s): One time run at first, potentially as needed afterwards
Estimated number of pages affected: 5173 at first (https://petscan.wmflabs.org/?psid=8047028)
Exclusion compliant (Yes/No): Yes
Already has a bot flag (Yes/No): Yes
Function details: Go through :Category:Articles needing translation from French Wikipedia. If {{tl|Infobox French commune}} is present, set the {{tl|Expand French}} |topic
parameter to be |topic=geo
=Discussion=
- {{ping|Sadenar40000}} filed! --DannyS712 (talk) 10:13, 1 March 2019 (UTC)
- {{t|BAGAssistanceNeeded}} --DannyS712 (talk) 19:33, 10 March 2019 (UTC)
- {{BotTrial|edits=50}} Primefac (talk) 19:46, 10 March 2019 (UTC)
- :{{ping|Primefac|Sadenar40000}} {{BotTrialComplete}} - I didn't spot any errors. 50 edits made [https://en.wikipedia.org/w/index.php?limit=1000&title=Special%3AContributions&contribs=user&target=DannyS712+bot&namespace=&tagfilter=&start=2019-03-10&end=2019-03-10 here] (search for "topic=geo"). Thanks, --DannyS712 (talk) 22:59, 10 March 2019 (UTC)
::{{ping|DannyS712}} Not sure if the bot is the cause, but Bouzeron and Amelécourt, the 2 first articles of the trial, have an added redlinked category named :Category:Geo articles needing translation from French Wikipedia, although the 48 others are perfect. Sadenar40000 (talk) 00:05, 11 March 2019 (UTC)
:::{{ping|Sadenar40000}} All of the other pages had {{tl|Expand French}} - those 2 had {{tl|expand language}}. My mistake - those 2 I did manually before telling AWB to auto save. I'll adjust the regex to skip pages with {{tl|expand language}} instead of {{tl|Expand French}}; Ideally, all {{tl|expand language}}s should be replaced by the language corresponding to langcode
, but that is a task for later. Sorry, --DannyS712 (talk) 00:08, 11 March 2019 (UTC)
::::No problem, I'll post another request for that task tomorrow then.Sadenar40000 (talk) 00:10, 11 March 2019 (UTC)
:::Alternatively, it works with {{tl|expand language}} if the topic is set to Geography
([https://en.wikipedia.org/w/index.php?title=Bouzeron&type=revision&diff=887163173&oldid=887151434&diffmode=source] [https://en.wikipedia.org/w/index.php?title=Amel%C3%A9court&type=revision&diff=887163207&oldid=887151385&diffmode=source]) so I could try that instead, but maybe that should be a separate task --DannyS712 (talk) 00:11, 11 March 2019 (UTC)
::::It would be added complexity for no benefit, a switch would be wiser, but that is, once again, a discussion for another request. Sadenar40000 (talk) 00:14, 11 March 2019 (UTC)
:::::{{ping|DannyS712}} All of the 41 communes that turned up after a petscan of :Category:Articles needing translation from French Wikipedia have had their expand language template switched to expand French, I am pretty sure there is no need to add a skip anymore. Sadenar40000 (talk) 23:44, 11 March 2019 (UTC)
::::::{{ping|Sadenar40000}} Okay. Thanks for running through that - I think this is ready to go then? {{ping|Primefac|p=?}} --DannyS712 (talk) 23:46, 11 March 2019 (UTC)
- {{BotApproved}} though {{ping|DannyS712}} unless there is a good reason not to, you should additionally use the 'minor' flag on this run. Will leave that option to your discretion. — xaosflux Talk 13:23, 12 March 2019 (UTC)
:The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.