Wikipedia:Bots/Requests for approval/FireflyBot II 2

{{Newbot|FireflyBot II|2}}

Operator: {{botop|Firefly}}

Time filed: 12:32, Sunday, November 21, 2021 (UTC)

Automatic, Supervised, or Manual: automatic

Programming language(s): Python

Source code available: https://gist.github.com/rwjuk/8691aacea7b66a7ae32c2308d3237e07

Function overview: Fixing duplicate references in articles caused by phab:T296044

Links to relevant discussions (where appropriate): BOTREQ and VPT thread

Edit period(s): One time run

Estimated number of pages affected: Upper bound 1,234 (based on [https://quarry.wmcloud.org/query/60049 this query])

Exclusion compliant (Yes/No): Yes

Already has a bot flag (Yes/No): Yes

Function details: Bot will repair any duplicated references caused by the VE bug mentioned above.

Scope will be limited to the ~1000 pages or so that had VE edits during the rough period (2100 on 18/11 to 0200 on 19/11) when the buggy code was deployed, to limit the chances of it 'fixing' cases where the two references have been defined with different content. (See [https://quarry.wmcloud.org/query/60049 query] that will be used.)

Intending to use the "FireflyBot II" account to segregate the edits from the continuous-run jobs on my other bot account (there's also a fun coincidence about FireflyBot II patching over another MediaWiki bug :') ), but if BAG feel that is a bad idea, I'm happy to use "I".

{{BotTrial|edits=25}} ProcrastinatingReader (talk) 13:06, 21 November 2021 (UTC)

:{{bottrialcomplete}} Thanks ProcrastinatingReader - diffs [https://en.wikipedia.org/wiki/Special:Contributions/FireflyBot_II here]. Two issues, one [https://en.wikipedia.org/w/index.php?title=Brexit&diff=prev&oldid=1056393604 here] caused by me stupidly forgetting to exclude no-content ref tags (causing the bot to remove ref content where a ref was invoked before it was defined), and one [https://en.wikipedia.org/w/index.php?title=Ded_(band)&diff=prev&oldid=1056400826 here] down to mwparserfromhell having a somewhat expansive view of what a 'tag' is... :P. Both fixed, code updated. firefly ( t · c ) 15:57, 21 November 2021 (UTC)

::Looks good. Let's do another quick trial (50 edits) to make sure there's no other edge cases. {{BotExtendedTrial|edits=50}} ProcrastinatingReader (talk) 16:42, 21 November 2021 (UTC)

:::@ProcrastinatingReader - thanks, see [https://en.wikipedia.org/wiki/Special:Contributions/FireflyBot_II here] again. No edge-cases that I can see this time. :) firefly ( t · c ) 17:43, 21 November 2021 (UTC)

::::{{bottrialcomplete}} Whoops - forgot this for Anomiebot. firefly ( t · c ) 17:51, 21 November 2021 (UTC)

:::::{{BotApproved}} LGTM. ProcrastinatingReader (talk) 18:08, 21 November 2021 (UTC)

:The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at Wikipedia:Bots/Noticeboard.