Wikipedia talk:Scripts++/Issue 25

I'm using Vector 2022's dark node and the headers appear to be invisible (see [https://en.wikipedia.org/w/index.php?title=User_talk:Rexogamer&oldid=1237915294#Scripts++_Newsletter_%E2%80%93_Issue_25 here] with dark mode enabled). I'm assuming this is down to the light background + the fact that headers are white by default... though maybe the real issue is said light background? but most of the text seems to be black so I'm a bit confused. hmmm... Rexo (talk | contributions) 13:57, 1 August 2024 (UTC)

:Yeah, that is a problem caused by the hardcoded light background. I'll see if there's some Codex color suited to our needs. Aaron Liu (talk) 18:59, 1 August 2024 (UTC)

::Aaron Liu, I've fixed the /Shell template earlier today (together with /Next), the variable --background-color-neutral-subtle gives color {{color box|#f8f9fa}} #f8f9fa. The previously hard-coded color was {{color box|#f8f8f8}} #f8f8f8. Seems like a good replacement to me.

::If you agree, I also plan to update all archived issues. But not the already sent out talk page messages, of course, – that would be too much spam in watchlists. —⁠andrybak (talk) 19:05, 1 August 2024 (UTC)

:::I'd agree, thanks! I found #f8f9fa from the Codex docs but couldn't find the classname for it. Where do you find these classes? Aaron Liu (talk) 19:06, 1 August 2024 (UTC)

::::I just typed --background-color in developer tools in Firefox, and scrolled through the list of auto-complete suggestions. —⁠andrybak (talk) 19:12, 1 August 2024 (UTC)

:::::Ah, ok. Anyways, I just searched that up in Google with double quotes for an exact match and found [https://doc.wikimedia.org/codex/latest/design-tokens/color.html]. Aaron Liu (talk) 19:17, 1 August 2024 (UTC)

::::::This is also linked on mw:Codex. —⁠andrybak (talk) 19:18, 1 August 2024 (UTC)

:::Re: {{tq|plan to update all archived issues}} – {{Done}} in these [https://en.wikipedia.org/wiki/Special:Contributions/Andrybak?limit=25&offset=20240801192640001 25 edits] + Special:Diff/1238032997 —⁠andrybak (talk) 19:28, 1 August 2024 (UTC)

::::By the way, the recommendation to use this approach is described at mw:Recommendations for night mode compatibility on Wikimedia wikis#Always define color when defining background. —⁠andrybak (talk) 08:28, 9 August 2024 (UTC)